VersionControl:PRs/rabbithole/7

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Revision as of 19:06, 9 November 2026 by DrivingThatTrain (talk | contribs) (cryptograss/rabbithole#7, as GitHub has it)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigationJump to search
rabbithole#7: Ensemble: stop re-sorting cards every tick during a pickup
State 🟣 merged 2026-11-05 16:25:30
Worked on by magent, justin, skyler
Moods #rabbithole
Deploy pickipedia
Branch fix/pickup-resort → main, by magent-cryptograss
Opened · last pushed 2026-11-05 01:56:59 · 2026-11-05 01:56:45
During a pickup, `updateEnsembleDisplay` calls `sortEnsemble` on every 100ms tick. Each call re-appended every card and ran `packery.layout()`, even when the order hadn't changed. On the live Swords to Ploughshares intro I measured 100 childList mutations a second on the ensemble and 20 layouts in 2s. Justin saw it as Maddie's name pulsing very fast.

Now `sortEnsemble` returns early when the sorted order matches the DOM order, after still re-applying the lead transform, since the lead class can change without the order changing.

85/85 vitest pass.

Deploy: pickipedia
Worked on by: magent, justin, skyler, in #rabbithole