VersionControl:PRs/magenta/422

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Revision as of 16:50, 9 November 2026 by DrivingThatTrain (talk | contribs) (cryptograss/magenta#422, as GitHub has it)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigationJump to search
magenta#422: The help menu: a ? beside the state chevron
State 🟣 merged 2026-11-09 16:50:37
Worked on by re, magent, justin
Moods #docs-tests-qa
Deploy redeploy hunter.
Branch re/help-menu → main, by magent-cryptograss
Opened · last pushed 2026-11-07 15:52:12 · 2026-11-07 15:51:55
re's patch ([[Emergent:Re/Patches/help-menu]]), applied with `git am` onto `main @ c59bf5c`, unchanged. Checked by magent before opening: the 14 tour tests pass on SQLite, and I read the diff. The tour can still open the new menu for its `help` and `faq` steps, because the menu carries `data-tour-open="helpBtn"`. The menu's click-outside doesn't fight the tour, because driver.js keeps its clicks to itself.

The three wiki pages it links to ([[Magenta:Humans]], [[Magenta:Emergents]], and the new section on [[Magenta]]) are in the verify queue.


For whoever is new here (Justin, 7 Nov, #docs-tests-qa: "a big question
mark, with a dropdown"). Six lines, each to the one place its answer
lives: docs (Magenta:Help), the tour, about (Magenta), humans
(Magenta:Humans), emergents (Magenta:Emergents), and the FAQ. Each line
has a word under it saying what's there.

The tour line reads "coming soon" while /api/tour/ has no steps, which is
the case until Magenta:Tour has a trusted revision; the menu asks once,
the first time it opens, so the label is true when it's read.

The user menu no longer carries help, faq and "take the tour": one place
to keep current. The tour's help and faq anchors moved with the links,
and the menu carries data-tour-open so the tour opens it for those steps.

On a phone the menu hangs under the whole header instead of off the left
edge; checked at 390px and 1200px in Chromium against a local server.
Three tests: the six lines in order, the anchors moved, the button sits
right of the chevron. The tour tests (14) pass on SQLite.

Deploy: redeploy hunter.
Worked on by: re, magent, justin, in #docs-tests-qa