VersionControl:PRs/magenta/462
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
| State | 🟢 open |
|---|---|
| Worked on by | magent, justin |
| Moods | #interfaces |
| Deploy | redeploy maybelle (memory-lane); no migrations |
| Branch | magent/cand-line-ramp-mood → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-10 16:05:56 · 2026-11-10 16:05:40 |
Justin, 10 Nov (#interfaces), after #453: "Let's have them appear on the third line, after the usage metrics. And let's have at most three of them appear on a line, and break to the next line after that. Also, in the ramp view, if I click on a mood name, instead of taking me directly to that mood, I'd rather have it filter the list to show only CBs from that mood (in all of the categories - open, merged, etc)."
**Mood list**
- Candidate chips move out of the title line onto their own line, right after the usage numbers and before the people line. 🔨 and 🖥️ asks stay in the title.
- **At most three a row.** A row breaks after every third chip. A narrow nav fits fewer.
- I tried a fixed three-column grid first, but at the default nav width (189px) it cut every name to "ca…".
- **Names:** each chip shows the branch name after the owner's ("candidates", not "magent/candidates") so more fit. Hovering shows the whole ref, e.g. `magenta#451 (magent/candidates)`, and who asked.
- Checked with injected rows at nav widths 189 and 300. At 189: one or two to a row. At 300: three, then a break.
**Ramp**
- Clicking a Mood's name in "where", on an open or a merged row, now filters both tables to that Mood's candidates instead of opening the Mood.
- A line above the list says "Only candidates from #interfaces, open and merged: 7 of 17", with an "every Mood" button. Clicking the same name again also clears it.
- Ctrl- or cmd-click still opens the Mood.
- It combines with the who buttons: a row shows only if both filters let it through.
- The filter isn't remembered: it's a quick look, not a setting.
- Checked against a local server: the page stayed on `/ramp/`, the filter kept #interfaces' rows and hid the rest, and "every Mood" brought back all 17.
**Tests:** `RampMoodFilterTest` is new. The who/where test now expects `data-moods`. The full suite ran 1,954 tests; its one failure was that assertion, which now passes along with `test_ramp`, `test_work_followups` and `test_tools_ask` (116 OK).
Deploy: redeploy maybelle (memory-lane); no migrations
Worked on by: magent, justin, in #interfaces