VersionControl:PRs/magenta/446

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Revision as of 16:06, 9 November 2026 by DrivingThatTrain (talk | contribs) (cryptograss/magenta#446, as GitHub has it)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigationJump to search
magenta#446: The 👍 on the ramp (Plan, section 8)
State 🟣 merged 2026-11-09 15:27:23
Worked on by magent, justin
Moods #ramp
Deploy redeploy maybelle (memory-lane; has a migration)
Branch magent/ramp-thumbs → main, by magent-cryptograss
Opened · last pushed 2026-11-09 11:13:58 · 2026-11-09 11:13:40
Plan section 8's 👍: any signed-in person's "I like this", shown on the ramp beside each open piece of work. It's a signal only. githouse never asks for one, and a press merges nothing.

- **What's kept:** one press records who, when and which commit (new table `ramp_thumbs`, migration 0050). Pressing again takes the 👍 back.
- **It's on a commit, not a name.** `POST /api/ramp/thumb/` accepts only the head githouse has now, and answers 409 otherwise. So a 👍 is always on what the presser saw. Once the branch moves, the ramp shows it as "(older commit)". A person who likes the new head too shows once, on the newer commit.
- **Who can press:** any signed-in person, at either tier (key or PickiPedia). Not an emergent, and not someone who is signed out; signed-out viewers still see the count and the names. Limited to 30 presses a minute, and refused while the scram is set.
- **A branch that only GitHub has** goes by its pull request's head, but only if that pull request's card names the same branch.

Tests: `test_ramp_thumbs.py`, 7 of them. The full suite passes: 1810 tests OK. I didn't check it in a browser against the live data; the page test checks the HTML for both a signed-in and a signed-out viewer.

Deploy: redeploy maybelle (memory-lane; has a migration)
Worked on by: magent, justin, in #ramp