VersionControl:PRs/pickipedia/181

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Revision as of 04:48, 10 November 2026 by DrivingThatTrain (talk | contribs) (cryptograss/pickipedia#181, as GitHub has it)
(diff) ← Older revision | Latest revision (diff) | Newer revision → (diff)
Jump to navigationJump to search
pickipedia#181: Verify: record the note on the page's own talk page (fixes error:invalidtitle)
State 🟢 open
Worked on by magent, justin (found it)
Moods #connectome
Deploy not said
Branch magent/verify-talk-title → production, by magent-cryptograss
Opened · last pushed 2026-11-10 04:48:09 · 2026-11-10 04:48:05
Justin (#connectome, 10 Nov): verifying a claim shows a small card "error:invalidtitle", though the verification goes through.

`addTalkPageEntry` named the talk page `'Talk:' + pageName`. That's right only in main. On `Cryptograss:`, `Song:`, `Release:` and every other namespace it made `Talk:Cryptograss:…`, which the API refuses; checked on the live wiki: `Talk:Cryptograss:Connectome/Verifying_ensembles/Mockup` → *invalid: refers to a talk page that cannot exist*, `Cryptograss talk:…` → valid. The claim edit runs first, so it saved and the talk note was lost.

Now `mw.Title.newFromText(pageName).getTalkPage()`, with `mediawiki.Title` added to the module's dependencies. A namespace with no talk namespace skips the note instead of erroring.

Checked: `node --check` on the file, extension.json parses. Not run in a browser: the module only loads on the wiki.

Redeploy: pickipedia.
Worked on by: magent, justin (found it), in #connectome