VersionControl:PRs/pickipedia/182

From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
pickipedia#182: Verify: correct before verifying; note and source in the dialog; the queue grouped (includes #181)
State 🟢 open
Worked on by magent, justin (the asks)
Moods #connectome
Deploy not said
Branch magent/verify-grouped → production, by magent-cryptograss
Opened · last pushed 2026-11-10 04:52:58 · 2026-11-10 04:52:43
Justin, #connectome, 10 Nov. **Includes #181** (the invalidtitle fix), whose talk-page function this extends; merge #181 first.

**The dialog**
- A `<proposed>` claim's wikitext comes in an editable box. What the person leaves there is what's verified; unchanged stays byte for byte. The talk-page entry records *Corrected from / to*. Older `{{Bot_proposes}}` markers, found only by their rendered text, keep the read-only line, since a correction there could land on the wrong text.
- `<proposed note="…">` (new attribute) fills the Note field and shows in the byline: `note="supporting text"` for words that only explain the page.
- A source that's a URL shows as a box: host in bold, path, **Open the full source ↗** (new tab). A real preview of the page itself isn't possible from the browser (most sources refuse framing); an excerpt attribute is a possible follow-up.

**Special:VerifyBotEdits**
- Grouped into: records/recordings/lineups, people and bands, shows/venues/festivals/scenes, songs, releases, podcasts, project pages, data model, everything else. A list of groups at the top with page and claim counts; `?kind=lineups` shows one group.
- Each row: claim count (`<proposed>` plus old `{{Bot_proposes}}`) and the sources the claims name; within a group, pages naming the same source sort together.
- *Verify All* only on the whole list, since it posts no page list and would otherwise verify groups you aren't looking at.

**What the live queue looks like** (surveyed via the API before building): 302 pages; 349 `<proposed>` claims and 1,842 `{{Bot_proposes}}`; **one** of the 349 names a source. So grouping by source shows little until the MCP writes `source=`/`note=` from the edit, a separate pickipedia-mcp PR.

**Tests:** new `check-verify-groups.php` (22 checks, real titles from the queue; wired into checks.yml and Jenkinsfile); `check-proposed-tag.php` +5 (note attribute, escaping); `check-verify-js.mjs` +11 (correction, source link incl. `javascript:`). All existing checks pass. Not run inside a live MediaWiki: the Special page's category query and namespace lookup are exercised only on deploy.

Redeploy: pickipedia.
Worked on by: magent, justin (the asks), in #connectome