VersionControl:PRs/rabbithole/21
From PickiPedia: A knowledge base of bluegrass, old time psychedelic jams, and other public domain music
Jump to navigationJump to search
| State | 🟣 merged 2026-11-07 16:20:27 |
|---|---|
| Worked on by | magent, skyler |
| Moods | #rabbithole |
| Deploy | not said |
| Branch | editor-sections → main, by magent-cryptograss
|
| Opened · last pushed | 2026-11-07 01:06:38 · 2026-11-07 01:06:34 |
On Paint Exchange, the ▶ beside every marker but the first played from the top of the song (Skyler, #rabbithole, 6 Nov 2026). Cause: that chart, like August's, is written in sections (`section2`, `section3`... laid out by `standardSectionLength`), and the editor has only ever read marker keys with `parseFloat`, so every section marker was `NaN`, the seek threw ("non-finite currentTime") and Webamp played from 0. Charts written in seconds, like Swords, never showed it. Same before the Vue conversion.
Now `EditableTrackData` opens a sectioned chart resolved to seconds, by the player's own `processTimeline`, with the section flags stripped; a restored backup gets the same. Opening is not an edit (the Save button reads "No changes"); the next save a person makes writes the same chart in seconds, which is the representation the editor has always written. A moment inside a section carries the section's arrangement, as the player already plays it.
Checked on pickipedia.xyz with the branch's build routed in: Paint Exchange's 27 markers all carry times, ▶ on marker 5 plays from 23.5 from a standing start, ▶ on marker 10 jumps to 58.75 mid-song, no console errors. 155 tests pass.
Redeploy: pickipedia
Worked on by: magent, Skyler, in #rabbithole